Skip to content

Payment: no retry, and better exception handling #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Payment: no retry, and better exception handling #858

wants to merge 4 commits into from

Conversation

@Marc-Andrieu
Copy link
Member

@Marc-Andrieu Marc-Andrieu commented Sep 26, 2025

Description

Summary

See title

Related Issues

Changes Made

  • Use 400 errors
  • Simpler structure: no nested trys
  • Short and straight-to-the-point exception logs

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Database migrations required
  • Other

Testing

  • Added/modified tests that pass the CI
  • Tested in a pre-prod
  • Tested this locally

Documentation

  • Updated docs accordingly (docs.myecl.fr) :
  • Code includes docstrings
  • Inline comments
  • No documentation needed

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Any dependent changes have been merged and published (Indicate the linked PR for the dependent changes)

Additional Notes

Add any other context, screenshots, or information about the pull request here.

@codecov
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.45%. Comparing base (5ff42fd) to head (910e467).

Files with missing lines Patch % Lines
app/core/payment/payment_tool.py 61.53% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #858      +/-   ##
==========================================
- Coverage   85.45%   85.45%   -0.01%     
==========================================
  Files         188      188              
  Lines       14310    14304       -6     
==========================================
- Hits        12229    12223       -6     
  Misses       2081     2081

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Marc-Andrieu Marc-Andrieu mentioned this pull request Sep 29, 2025
Open
21 tasks
@Marc-Andrieu Marc-Andrieu self-assigned this Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Marc-Andrieu Marc-Andrieu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Marc-Andrieu